Bug 257685

Summary: [IFC] Remove redundant LineBuilder::computedIntrinsicWidth
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
[fast-cq]Patch none

Description zalan 2023-06-03 21:11:28 PDT
ssia
Comment 1 zalan 2023-06-03 21:35:57 PDT
Created attachment 466586 [details]
Patch
Comment 2 Antti Koivisto 2023-06-05 01:54:31 PDT
Comment on attachment 466586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466586&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:431
> -        auto intrinsicContent = lineBuilder.computedIntrinsicWidth({ layoutRange, { 0.f, 0.f, horizontalConstraints.logicalWidth, 0.f } }, previousLine);
> +        auto lineLayoutResult = lineBuilder.layoutInlineContent({ layoutRange, { 0.f, 0.f, horizontalConstraints.logicalWidth, 0.f } }, previousLine);

nice!
Comment 3 zalan 2023-06-05 11:26:47 PDT
Created attachment 466595 [details]
[fast-cq]Patch
Comment 4 EWS 2023-06-05 13:32:28 PDT
Committed 264872@main (e25dc4918f88): <https://commits.webkit.org/264872@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466595 [details].
Comment 5 Radar WebKit Bug Importer 2023-06-05 13:33:21 PDT
<rdar://problem/110273921>