Bug 257650
| Summary: | Move WebCore::RunLoopObserver from WebCore/platform/cf to WebCore/platform | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> |
| Component: | Platform | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dpino, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 257622 | ||
Wenson Hsieh
...so that we can use it in (otherwise) platform-agnostic code.
For now, this will only have a concrete implementation when `USE(CF)` is defined, but we could make it work with other ports (e.g. `GLIB_EVENT_LOOP` / `WINDOWS_EVENT_LOOP`) as well, in a followup.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Wenson Hsieh
Pull request: https://github.com/WebKit/WebKit/pull/14630
Radar WebKit Bug Importer
<rdar://problem/110531974>
EWS
Committed 265089@main (a1236fc76789): <https://commits.webkit.org/265089@main>
Reviewed commits have been landed. Closing PR #14630 and removing active labels.
Diego Pino
WebKitGTK Release post-commit build bot is failing after this patch landed:
https://build.webkit.org/#/builders/41/builds/19615/steps/10/logs/stdio
from /app/webkit/Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp:21,
from /app/webkit/WebKitBuild/Release/WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-51.cpp:1:
/app/webkit/Source/WebCore/platform/VideoEncoderActiveConfiguration.h:35:12: error: field ‘codec’ has incomplete type ‘WTF::String’
35 | String codec;
| ^~~~~
It's a non-unified sources build error, `#include <WTFString.h>` is missing.
Diego Pino
Re-opening for pull request https://github.com/webkit/webkit/pull/14907
EWS
Committed 265105@main (90873fe270bf): <https://commits.webkit.org/265105@main>
Reviewed commits have been landed. Closing PR #14907 and removing active labels.