Bug 257641
| Summary: | Remove unnecessary check in `TreeResolver::resolvePseudoElement()` | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Vitaly Dyackhov <vitaly> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Vitaly Dyackhov
```
// FIXME: This test shouldn't be needed.
bool alwaysNeedsPseudoElement = resolvedStyle->style->hasAnimationsOrTransitions()
|| element.hasKeyframeEffects(pseudoId)
|| pseudoId == PseudoId::FirstLine
|| pseudoId == PseudoId::FirstLetter
|| pseudoId == PseudoId::Scrollbar;
if (!alwaysNeedsPseudoElement && !pseudoElementRendererIsNeeded(resolvedStyle->style.get()))
return { };
```
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Vitaly Dyackhov
Pull request: https://github.com/WebKit/WebKit/pull/14620
Radar WebKit Bug Importer
<rdar://problem/110515283>
EWS
Committed 265318@main (ad52c1163560): <https://commits.webkit.org/265318@main>
Reviewed commits have been landed. Closing PR #14620 and removing active labels.