Summary: | Missing padding-end, margin-end etc. | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Erik Arvidsson <arv> | ||||||||||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | benjamin.ach, commit-queue, hamaji, msfeldstein+bugzilla, oded, ojan | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
URL: | http://dev.w3.org/csswg/css3-text-layout/ | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 41496 | ||||||||||||||
Attachments: |
|
Description
Erik Arvidsson
2009-05-13 15:06:33 PDT
Agree - there should be *-end properties Hello, I must use these properties for the RTL mode of my webapplication. Could you please fix it ? Please confirm the bug. You can check at http://help.dottoro.com/lchucsdq.php#-webkit-padding-end and see the bug (check also "padding-start" to see it working normaly). *** Bug 41322 has been marked as a duplicate of this bug. *** Created attachment 60311 [details]
Patch
Created attachment 60312 [details]
Patch
Created attachment 60314 [details]
Remove trailing whitespace
Comment on attachment 60314 [details]
Remove trailing whitespace
I need to make the tests actually test rtl.
Created attachment 60320 [details]
Make tests cover RTL as well
Hamaji, could you review this? Comment on attachment 60320 [details]
Make tests cover RTL as well
Rejecting patch 60320 from commit-queue.
Unexpected failure when processing patch! Please file a bug against webkit-patch.
Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 60320, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1
Last 500 characters of output:
date_status
return NetworkTransaction().run(lambda: self._post_status_to_server(queue_name, status, patch, results_file))
File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/common/net/networktransaction.py", line 56, in run
self._check_for_timeout()
File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/common/net/networktransaction.py", line 63, in _check_for_timeout
raise NetworkTimeout()
webkitpy.common.net.networktransaction.NetworkTimeout
Created attachment 60805 [details]
Patch for landing
Comment on attachment 60805 [details] Patch for landing Rejecting patch 60805 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 19307 test cases. fast/loader/recursive-before-unload-crash.html -> failed Exiting early after 1 failures. 14202 tests run. 260.93s total testing time 14201 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/3425031 Comment on attachment 60805 [details] Patch for landing Bug 41871 Comment on attachment 60805 [details] Patch for landing Rejecting patch 60805 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1 Last 500 characters of output: k #1 FAILED at 215. Hunk #2 FAILED at 240. 2 out of 2 hunks FAILED -- saving rejects to file WebCore/css/CSSPropertyNames.in.rej patching file WebCore/css/CSSStyleSelector.cpp Hunk #1 FAILED at 3109. Hunk #2 FAILED at 5506. 2 out of 2 hunks FAILED -- saving rejects to file WebCore/css/CSSStyleSelector.cpp.rej patching file WebCore/inspector/front-end/SourceCSSTokenizer.js Hunk #1 FAILED at 81. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/inspector/front-end/SourceCSSTokenizer.js.rej Full output: http://webkit-commit-queue.appspot.com/results/3487059 |