Bug 257575
| Summary: | RenderTable::BottomSection() should return the last rendered table section | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Layout and Rendering | Assignee: | Karl Dubost <karlcow> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, karlcow, ntim, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://github.com/web-platform-tests/wpt/pull/50328 | ||
Ahmad Saleem
Hi Team,
Just came across following potential bug fix but without Layout Test case, so I would leave it for someone else to fix but just wanted to raise.
Blink Commit: https://chromium.googlesource.com/chromium/src.git/+/9c14979722d3761c5449f3ef9f68bd2fee4f82a0
WebKit Source: https://github.com/WebKit/WebKit/blob/734687da6292d68e3d571f781719887cc8e74bbd/Source/WebCore/rendering/RenderTable.cpp#L1435
Patch:
if (m_foot)
return m_foot.get();
if (m_head && !firstBody())
return m_head.get();
for (RenderObject* child = lastChild(); child; child = child->previousSibling()) {
if (child == m_head)
continue;
____________-
Just wanted to raise, so we can fix it.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
alan
I think this needs a test case and it should not be too hard to come up with one.
Radar WebKit Bug Importer
<rdar://problem/110430887>
Karl Dubost
Alan, do you have an example of CPP test file elsewhere in the code?
Karl Dubost
Pull request: https://github.com/WebKit/WebKit/pull/39589
Tim Nguyen (:ntim)
WPT PR: https://github.com/web-platform-tests/wpt/pull/50328
EWS
Committed 289434@main (1d539b1ae929): <https://commits.webkit.org/289434@main>
Reviewed commits have been landed. Closing PR #39589 and removing active labels.