Bug 257500
| Summary: | Use StringView more in ScriptElement and EmailInputType | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Anne van Kesteren <annevk> |
| Component: | DOM | Assignee: | Anne van Kesteren <annevk> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Anne van Kesteren
As suggested here https://github.com/WebKit/WebKit/pull/14467#pullrequestreview-1451367941.
The event and for attribute values are used for comparisons only, so StringView would be more efficient. Looks like there is no need to convert from AtomString to String for these either.
RegularExpression::match() already takes a StringView so updating isValidEmailAddress() should be straightforward.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/110047074>
Anne van Kesteren
Pull request: https://github.com/WebKit/WebKit/pull/14527
EWS
Committed 264736@main (f8eaba1e9189): <https://commits.webkit.org/264736@main>
Reviewed commits have been landed. Closing PR #14527 and removing active labels.