Bug 25731

Summary:

[Qt] Cleanup - move files exclusive to XPATH and XSLT under the appropriate build section

Product:

WebKit

Reporter:

Laszlo Gombos <laszlo.gombos>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Proposed cleanup.	zecke: review+

Laszlo Gombos

Reported 2009-05-12 10:42:56 PDT

Benefits: - the feature configuration handling for XPATH and XSLT will be consistent with other guards withing Qt port - should make builds faster if the feature is disabled

Attachments
Proposed cleanup. (3.97 KB, patch) 2009-05-12 10:45 PDT, Laszlo Gombos	zecke: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Laszlo Gombos

Comment 1 2009-05-12 10:45:42 PDT

Created attachment 30241 [details] Proposed cleanup.

Laszlo Gombos

Comment 2 2009-05-12 10:49:57 PDT

Comment on attachment 30241 [details] Proposed cleanup. +!contains(DEFINES, ENABLE_XSLT=.): DEFINES += ENABLE_XSLT=0 makes it explicit and more obvious that XSLT is turned off by default for the Qt port (as it was before).

Holger Freyther

Comment 3 2009-05-14 20:33:57 PDT

Comment on attachment 30241 [details] Proposed cleanup. Nice.

Eric Seidel (no email)

Comment 4 2009-05-15 00:06:52 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/WebCore.pro Committed r43758

Note You need to log in before you can comment on or make changes to this bug.