Bug 257276
| Summary: | [Xcode] Dependencies in preprocessed sandbox profiles not tracked | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Elliott Williams <emw> |
| Component: | Tools / Tests | Assignee: | Elliott Williams <emw> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 257814 | ||
| Bug Blocks: | |||
Elliott Williams
Xcode-based ports use a Makefile to run *.sb.in files through clang, to "preprocess" them and support feature flags and rudimentary includes. This means that files that are included are unknown to the build system, so changes in e.g. "common.sb" do not re-generate the sandbox profiles.
Let's move this process over to build rules and emit a discovered dependency file.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/109790387>
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/14302
EWS
Committed 264612@main (40fd93b1f2ef): <https://commits.webkit.org/264612@main>
Reviewed commits have been landed. Closing PR #14302 and removing active labels.
Elliott Williams
Re-opening for pull request https://github.com/WebKit/WebKit/pull/14515
EWS
Committed 264744@main (5f13e1c10eb0): <https://commits.webkit.org/264744@main>
Reviewed commits have been landed. Closing PR #14515 and removing active labels.
EWS
Committed 264752@main (6f04c95bf8f3): <https://commits.webkit.org/264752@main>
Reviewed commits have been landed. Closing PR #14553 and removing active labels.
Elliott Williams
Re-opening for pull request https://github.com/WebKit/WebKit/pull/14649
EWS
Committed 264904@main (c9a65a407c6b): <https://commits.webkit.org/264904@main>
Reviewed commits have been landed. Closing PR #14649 and removing active labels.
Elliott Williams
Reopening due to revert in https://bugs.webkit.org/show_bug.cgi?id=257814