Bug 257233
Summary: | [baseline-alignment] Rename BaselineContext | ||
---|---|---|---|
Product: | WebKit | Reporter: | Sammy Gill <sgill26> |
Component: | Layout and Rendering | Assignee: | Sammy Gill <sgill26> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Sammy Gill
Whenever we use BaselineContext for baseline alignment, it is continually modifying its state by inserting items into the appropriate baseline sharing groups. We should remove the "context," portion of this name and rename it to something a bit more appropriate that makes it obvious it is there to help manage the baseline sharing groups in different formatting contexts.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/109742609>
Sammy Gill
Also, a baseline alignment context is something that is part of a specific formatting context. For example, in flex layout the baseline alignment contexts are the flex lines.
Based off of that I don't think it's appropriate for a formatting context to "create" an object called BaselineContext
Sammy Gill
Pull request: https://github.com/WebKit/WebKit/pull/14271
EWS
Committed 264484@main (48c6a9eda4fd): <https://commits.webkit.org/264484@main>
Reviewed commits have been landed. Closing PR #14271 and removing active labels.