Bug 25716

Summary:

Non js test in editing/pasteboard/resources

Product:

WebKit

Reporter:

Julie Parent <jparent>

Component:

Tools / Tests

Assignee:

Julie Parent <jparent>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kmccullough

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Convert test into js test.	none
Convert test into js test, this time with proper indentation.	none
This time, with extra lie breaks!	eric: review+
New patch, just adds the resource to ignore list	eric: review+

Julie Parent

Reported 2009-05-11 22:13:32 PDT

http://trac.webkit.org/changeset/43255 added LayoutTests/editing/pasteboard/resources/paste-blockquote-before-blockquote.js, which is not a standard js test. For a change I'm working on, I'm adding some js tests for pasteboard, so I have added a TEMPLATE to LayoutTests/editing/pasteboard/resources. In order to add my js tests to this directory and run make-js-test-wrappers we'll need to do something about this test. Seems like the options are to convert it over to be a js test, or to add it to the ignore list in make-js-test-wrappers. Unless anyone objects, I'll just transform it into a regular js test.

Attachments
Convert test into js test. (6.47 KB, patch) 2009-05-11 23:30 PDT, Julie Parent	no flags	Details Formatted Diff Diff
Convert test into js test, this time with proper indentation. (6.48 KB, patch) 2009-05-11 23:34 PDT, Julie Parent	no flags	Details Formatted Diff Diff
This time, with extra lie breaks! (6.50 KB, patch) 2009-05-12 00:04 PDT, Julie Parent	eric: review+	Details Formatted Diff Diff
New patch, just adds the resource to ignore list (1.16 KB, patch) 2009-05-15 01:00 PDT, Julie Parent	eric: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Julie Parent

Comment 1 2009-05-11 23:30:04 PDT

Created attachment 30219 [details] Convert test into js test.

Julie Parent

Comment 2 2009-05-11 23:34:34 PDT

Created attachment 30220 [details] Convert test into js test, this time with proper indentation.

Julie Parent

Comment 3 2009-05-12 00:04:56 PDT

Created attachment 30221 [details] This time, with extra lie breaks!

Eric Seidel (no email)

Comment 4 2009-05-14 21:18:56 PDT

Comment on attachment 30221 [details] This time, with extra lie breaks! Looks fine.

Eric Seidel (no email)

Comment 5 2009-05-14 21:19:30 PDT

Comment on attachment 30221 [details] This time, with extra lie breaks! Looks like your environment still isn't perfect though: "Julie Jparent"

Eric Seidel (no email)

Comment 6 2009-05-14 21:34:52 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/editing/pasteboard/paste-blockquote-before-blockquote-expected.txt M LayoutTests/editing/pasteboard/paste-blockquote-before-blockquote.html A LayoutTests/editing/pasteboard/resources/TEMPLATE.html M LayoutTests/editing/pasteboard/resources/paste-blockquote-before-blockquote.js Committed r43753

Eric Seidel (no email)

Comment 7 2009-05-14 22:19:46 PDT

Rolled out in: Committing to http://svn.webkit.org/repository/webkit/trunk ... D LayoutTests/editing/pasteboard/resources/TEMPLATE.html M LayoutTests/ChangeLog M LayoutTests/editing/pasteboard/paste-blockquote-before-blockquote-expected.txt M LayoutTests/editing/pasteboard/paste-blockquote-before-blockquote.html M LayoutTests/editing/pasteboard/resources/paste-blockquote-before-blockquote.js Committed r43754 Julie, feel free to re-open if you plan to re-make this change.

Julie Parent

Comment 8 2009-05-15 01:00:53 PDT

Created attachment 30369 [details] New patch, just adds the resource to ignore list New approach - since resources/paste-blockquote-before-blockquote.js is used for multiple html tests, just ignore this file in make-js-test-wrappers.

Julie Parent

Comment 9 2009-05-15 01:02:03 PDT

Reopening with new fix to just ignore the file in make-js-test-wrappers instead.

Eric Seidel (no email)

Comment 10 2009-05-16 09:08:18 PDT

Comment on attachment 30369 [details] New patch, just adds the resource to ignore list The bug URL is in kinda a funny place for the ChangeLog. But this looks fine, will land on Monday.

Eric Seidel (no email)

Comment 11 2009-05-18 03:22:05 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/make-js-test-wrappers Committed r43820

Note You need to log in before you can comment on or make changes to this bug.