| Summary: | Need changes for new Skia API | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Stephen White <senorblanco> | ||||||||
| Component: | Layout and Rendering | Assignee: | Stephen White <senorblanco> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | dglazkov, senorblanco | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows XP | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Stephen White
2009-05-11 14:10:51 PDT
Created attachment 30203 [details]
Changes for new Skia API.
Comment on attachment 30203 [details]
Changes for new Skia API.
Don't forget the URL of the bug in the ChangeLog entry next time.
Created attachment 30245 [details]
Take two, compatible with both versions of skia.
On second thought, better to hide these changes behind an #ifdef for now, so we don't kill the canary. :) Comment on attachment 30245 [details]
Take two, compatible with both versions of skia.
even betterer.
Oh -- one thing. Can you replace TODO(senorblanco) with FIXME, to match WebKit style? And please add me to cc of bugs. Asking for review is like a one-time shot -- it doesn't let the reviewer to listen in on the conversation on the bug (if any). Created attachment 30246 [details]
Take three: FIXME instead of TODO(senorblanco)
Comment on attachment 30246 [details]
Take three: FIXME instead of TODO(senorblanco)
Great!
(In reply to comment #7) > And please add me to cc of bugs. Asking for review is like a one-time shot -- > it doesn't let the reviewer to listen in on the conversation on the bug (if > any). > Will do. (I assume you mean "in the future, I did it this time" since I see your name in the CC list already). I added myself :) Landed as http://trac.webkit.org/changeset/43584. |