Bug 257018

Summary:	webkitscmpy.program.pull_request should tell check-webkit-style the branch point
Product:	WebKit	Reporter:	Sam Sneddon [:gsnedders] <gsnedders>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	NEW
Severity:	Normal	CC:	jbedard, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Sam Sneddon [:gsnedders]

Reported 2023-05-19 03:28:41 PDT

Currently running `git-webkit pr` calls `check-webkit-style` by default. However, both commands run `Branch.branch_point` for the commit being pushed, and `Branch.branch_point` is famously slow (e.g., bug 256855). Instead of spending ~15s doing this twice, we should spend ~7.5s doing it once, and `git-webkit pr` should simply tell `check-webkit-style` what commit to use as the branch point.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-05-19 03:28:56 PDT

<rdar://problem/109558732>

Note You need to log in before you can comment on or make changes to this bug.