Bug 256855 - [git-webkit] Speed up Branch.branch_point
Summary: [git-webkit] Speed up Branch.branch_point
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-16 12:54 PDT by Jonathan Bedard
Modified: 2023-05-25 15:25 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-05-16 12:54:54 PDT 
Branch.branch_point is slow because it computes commit details for every commit in your history. We should use lighter-weight 'git' commands in this function, since it is a major contributor to 'git-webkit pr' being slow.
Comment 1 Radar WebKit Bug Importer 2023-05-16 12:55:21 PDT 
<rdar://problem/109419012>
Comment 2 Jonathan Bedard 2023-05-16 13:06:25 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13934
Comment 3 EWS 2023-05-25 13:45:50 PDT 
Committed 264536@main (295115e98b2e): <https://commits.webkit.org/264536@main>

Reviewed commits have been landed. Closing PR #13934 and removing active labels.
Comment 4 EWS 2023-05-25 15:25:43 PDT 
Committed 259548.782@safari-7615-branch (9d8c69db76df): <https://commits.webkit.org/259548.782@safari-7615-branch>

Reviewed commits have been landed. Closing PR #621 and removing active labels.