Bug 25697

Summary:	[GTK] Warnings building WebKit/gtk/tests/testwebframe.c
Product:	WebKit	Reporter:	David Kilzer (:ddkilzer) <ddkilzer>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	christian, jmalonzo, mrowe
Priority:	P2
Version:	528+ (Nightly build)
Hardware:	Mac
OS:	OS X 10.5
URL:	http://build.webkit.org/builders/GTK%20Linux%20Release/builds/314/steps/compile-webkit/logs/warnings

Description David Kilzer (:ddkilzer) 2009-05-11 10:00:00 PDT

* SUMMARY
There are compilation warnings building WebKit/gtk/tests/testwebframe.c:

../../WebKit/gtk/tests/testwebframe.c:45: warning: passing argument 2 of 'gtk_container_add' from incompatible pointer type
../../WebKit/gtk/tests/testwebframe.c:47: warning: passing argument 1 of 'gtk_widget_show' from incompatible pointer type
../../WebKit/gtk/tests/testwebframe.c:48: warning: passing argument 1 of 'gtk_widget_destroy' from incompatible pointer type

It appears that all of these methods want a GtkWidget* argument where the WebKitWebView* webView variable is used.

Comment 1 Christian Dywan 2009-05-11 17:50:20 PDT

2009-05-11  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=25697
        [GTK] Warnings building WebKit/gtk/tests/testwebframe.c

        * tests/testwebframe.c:
        (test_webkit_web_frame_create_destroy): Declare webView as a GtkWidget*
        to fix pointer type incompatibility warnings.

Comment 2 David Kilzer (:ddkilzer) 2009-05-11 17:58:40 PDT

Thanks!!  http://trac.webkit.org/changeset/43530