Summary: | Make sure to run a service worker before firing its activate event | ||
---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> |
Component: | Service Workers | Assignee: | youenn fablet <youennf> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | Hironori.Fujii, twisniewski, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Local Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=258021 https://bugs.webkit.org/show_bug.cgi?id=258502 |
Description
youenn fablet
2023-05-17 06:27:14 PDT
Pull request: https://github.com/WebKit/WebKit/pull/13961 Committed 264242@main (ff4eced3ff23): <https://commits.webkit.org/264242@main> Reviewed commits have been landed. Closing PR #13961 and removing active labels. Has the new WPT in this patch been sent to be synced upstream? I'm not seeing it on wpt.fyi or wpt.live. (I also note that `withIframe` isn't defined in the test itself, so it would be good to fix that before sending a PR). (In reply to Thomas Wisniewski [:twisniewski] from comment #4) > Has the new WPT in this patch been sent to be synced upstream? I'm not > seeing it on wpt.fyi or wpt.live. The test is in LayoutTests/http/wpt so it is separate from wpt.fyi. I guess we could upstream it though to help other browsers. Would that be of interest? withIFrame is defined in a JS file in wpt repo. Ah I see, thanks for the explanation! Yes, it would be great to have as much coverage in WPTs as possible instead of browser-specific test infrastructure, so that we can all ensure interop. Even where it isn't currently possible (due to lacking low-level APIs and such), it would be good to let the WPT team know what's missing to make it possible eventually. This doesn't have to be a high priority of course, but every little bit helps (especially with interop202x [1] being a thing; the better our coverage now, the less likely service workers will become a future focus area in that project). |