Bug 25684

Summary:

ScrollView::valueChanged compares the parameter pointer with m_verticalScrollbar/m_horizontalScrollbar

Product:

WebKit

Reporter:

Holger Freyther <zecke>

Component:

WebCore Misc.

Assignee:

Holger Freyther <zecke>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Use Scrollbar::orientation to get the orientation	mjs: review+

Holger Freyther

Reported 2009-05-10 22:48:12 PDT

While fixing a bug on GTK+ I noticed that ScrollView::valueChanged is using pointers to figure out the direction/axis of the scrolling. I couldn't find any reason for that, hence writing a bug report.

Attachments
Use Scrollbar::orientation to get the orientation (1.75 KB, patch) 2009-05-10 22:49 PDT, Holger Freyther	mjs: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Holger Freyther

Comment 1 2009-05-10 22:49:03 PDT

Created attachment 30173 [details] Use Scrollbar::orientation to get the orientation Why wasn't Scrollbar::orientation used for this? Is there any reason?

Maciej Stachowiak

Comment 2 2009-05-22 01:01:31 PDT

Comment on attachment 30173 [details] Use Scrollbar::orientation to get the orientation r=me

Holger Freyther

Comment 3 2009-05-22 22:48:19 PDT

Landed in r44079.

Note You need to log in before you can comment on or make changes to this bug.