Bug 256811

Summary:

textareas logical height with overflow auto shouldn't add scrollbar-thickness

Product:

WebKit

Reporter:

Luke Warlow <lwarlow>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

akeerthi, bfulgham, cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, karlcow, kondapallykalyan, mifenton, mmaxfield, pdr, simon.fraser, webkit-bug-importer, wenson_hsieh, zalan

Priority:

Keywords:

BrowserCompat, InRadar

Version:

Safari 16

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-

Description Luke Warlow 2023-05-15 15:18:20 PDT

Currently in WebKit if a textarea has overflow auto and overflow-wrap normal, it includes the scrollbar thickness in the logical height. This check doesn't exist in Firefox and no longer exists in Chrome as of https://chromium.googlesource.com/chromium/src/+/18481ffa332076e58fd9adbbea2062c2ba087dfb

It would be good to remove it from WebKit too for interop purposes.


if ((isHorizontalWritingMode() && (style().overflowX() == Overflow::Scroll ||  (style().overflowX() == Overflow::Auto && innerText->renderer()->style().overflowWrap() == OverflowWrap::Normal)))
    || (!isHorizontalWritingMode() && (style().overflowY() == Overflow::Scroll ||  (style().overflowY() == Overflow::Auto && innerText->renderer()->style().overflowWrap() == OverflowWrap::Normal))))
    logicalHeight += scrollbarThickness();

The above code inside of RenderTextControl.cpp would become something like the below code:

if ((isHorizontalWritingMode() && style().overflowX() == Overflow::Scroll)
    || (!isHorizontalWritingMode() && style().overflowY() == Overflow::Scroll))
    logicalHeight += scrollbarThickness();

Comment 1 Radar WebKit Bug Importer 2023-05-15 20:05:48 PDT

<rdar://problem/109384976>

Comment 2 zalan 2023-05-17 19:58:01 PDT

Created attachment 466393 [details]
Patch

Comment 3 zalan 2023-05-18 08:24:09 PDT

Created attachment 466398 [details]
Patch

Comment 4 zalan 2023-05-18 08:38:34 PDT

Created attachment 466399 [details]
Patch

Comment 5 Simon Fraser (smfr) 2023-05-18 14:05:09 PDT

Comment on attachment 466399 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466399&action=review

> COMMIT_MESSAGE:7
> +Merged from Blink: https://chromium.googlesource.com/chromium/src/+/18481ffa332076e58fd9adbbea2062c2ba087dfb

I would like some more words here, explaining when we get a behavior change.

> COMMIT_MESSAGE:14
> +* LayoutTests/platform/mac/fast/forms/basic-textareas-expected.txt: WebKit matches Chrome now.

Don't care if it matches Chrome :)

Comment 6 zalan 2023-05-19 06:39:27 PDT

Created attachment 466416 [details]
Patch

Comment 7 EWS 2023-05-19 07:53:43 PDT

Committed 264251@main (8b48b8b9e8b8): <https://commits.webkit.org/264251@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466416 [details].