Bug 256675
| Summary: | Use system malloc when MallocStackLogging is enabled | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ben Nham <nham> |
| Component: | bmalloc | Assignee: | Ben Nham <nham> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ggaren, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ben Nham
In 255601@main we added support for MallocStackLogging in libpas. This seems to work when using Instruments, but doesn't seem to work when capturing memgraphs. Since memgraphs are the most common way that other teams pass memory regression bugs to us, it's important that capturing stacks via memgraphs works by default. This change makes MallocStackLogging imply using system malloc so that stacks in memgraphs are present. You can still force MallocStackLogging with libpas by using MallocStackLogging=lite NO_DEBUG_HEAP=1 after this patch.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ben Nham
<rdar://problem/109233872>
Ben Nham
Pull request: https://github.com/WebKit/WebKit/pull/13783
EWS
Committed 264075@main (b6454a5cd58f): <https://commits.webkit.org/264075@main>
Reviewed commits have been landed. Closing PR #13783 and removing active labels.