Bug 256537

Summary: [Repaint] Cleanup RenderElement::repaintAfterLayoutIfNeeded
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 251176    
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

zalan
Reported 2023-05-09 11:36:39 PDT
ssia
Attachments
Patch (19.72 KB, patch)
2023-05-09 12:21 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (19.61 KB, patch)
2023-05-09 12:29 PDT, zalan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (19.69 KB, patch)
2023-05-09 16:01 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2023-05-09 12:21:31 PDT
Created attachment 466296 [details] Patch
zalan
Comment 2 2023-05-09 12:29:16 PDT
Created attachment 466297 [details] Patch
Simon Fraser (smfr)
Comment 3 2023-05-09 14:07:59 PDT
Comment on attachment 466297 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=466297&action=review > Source/WebCore/rendering/RenderElement.cpp:1287 > + auto width = absoluteValue(newOutlineAndBoxShadowBox.width() - oldOutlineAndBoxShadowBox.width()); Nicer to compute a size delta (with "delta" in the name).
zalan
Comment 4 2023-05-09 15:24:11 PDT
(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 466297 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=466297&action=review > > > Source/WebCore/rendering/RenderElement.cpp:1287 > > + auto width = absoluteValue(newOutlineAndBoxShadowBox.width() - oldOutlineAndBoxShadowBox.width()); > > Nicer to compute a size delta (with "delta" in the name). Good point!
zalan
Comment 5 2023-05-09 16:01:27 PDT
Created attachment 466300 [details] Patch
EWS
Comment 6 2023-05-09 19:32:33 PDT
Committed 263890@main (e10f145ce649): <https://commits.webkit.org/263890@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 466300 [details].
Radar WebKit Bug Importer
Comment 7 2023-05-09 19:33:19 PDT
<rdar://problem/109131286>
Note You need to log in before you can comment on or make changes to this bug.