Bug 25625

Summary:

Implement Image/Option constructors in V8

Product:

WebKit

Reporter:

Dimitri Glazkov (Google) <dglazkov>

Component:

WebCore Misc.

Assignee:

Dimitri Glazkov (Google) <dglazkov>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Implement Image/Option constructors in V8, v1	none
Implement Image/Option constructors in V8, v2	fishd: review+

Description Dimitri Glazkov (Google) 2009-05-07 12:12:52 PDT

This helps us unfork DOMWindow.idl

Comment 1 Dimitri Glazkov (Google) 2009-05-07 12:17:33 PDT

Created attachment 30108 [details]
Implement Image/Option constructors in V8, v1

 WebCore/ChangeLog                                  |   12 +++
 WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp   |   60 -------------
 .../v8/custom/V8HTMLImageElementConstructor.cpp    |   73 ++++++++++++++++
 .../v8/custom/V8HTMLOptionElementConstructor.cpp   |   90 ++++++++++++++++++++
 4 files changed, 175 insertions(+), 60 deletions(-)

Comment 2 Dimitri Glazkov (Google) 2009-05-07 12:28:15 PDT

Created attachment 30109 [details]
Implement Image/Option constructors in V8, v2

 WebCore/ChangeLog                                  |   12 +++
 WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp   |   60 -------------
 .../v8/custom/V8HTMLImageElementConstructor.cpp    |   73 ++++++++++++++++
 .../v8/custom/V8HTMLOptionElementConstructor.cpp   |   90 ++++++++++++++++++++
 4 files changed, 175 insertions(+), 60 deletions(-)

Comment 3 Dimitri Glazkov (Google) 2009-05-07 12:28:55 PDT

Comment on attachment 30108 [details]
Implement Image/Option constructors in V8, v1

Whoops. Fixing a few boogers.

Comment 4 Dimitri Glazkov (Google) 2009-05-10 11:41:45 PDT

Landed as http://trac.webkit.org/changeset/43360.