Bug 255993
| Summary: | Improve support for gradient in post-processed ImageData | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Matthew Finkel <m_finkel> |
| Component: | New Bugs | Assignee: | Matthew Finkel <m_finkel> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 256677 | ||
| Bug Blocks: | |||
Matthew Finkel
Improve support for gradient in post-processed ImageData
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Matthew Finkel
rdar://107371244
Matthew Finkel
Pull request: https://github.com/WebKit/WebKit/pull/13199
EWS
Committed 263979@main (eabcb3ec87c6): <https://commits.webkit.org/263979@main>
Reviewed commits have been landed. Closing PR #13199 and removing active labels.
Chris Dumez
I suspect this broke photo editing on https://photos.google.com:
```
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0 libsystem_kernel.dylib 0x1888421fc __pthread_kill + 8
1 libsystem_pthread.dylib 0x188879cc0 pthread_kill + 288
2 libsystem_c.dylib 0x188789a98 abort + 180
3 libc++.1.dylib 0x1887b4174 std::__1::__libcpp_verbose_abort(char const*, ...) + 92
4 WebCore 0x111fabbcc std::__1::optional<unsigned long long>::operator*[abi:v160002]() && + 48 (optional:971) [inlined]
5 WebCore 0x111fabbcc WebCore::CanvasBase::makeRenderingResultsAvailable() + 336 (CanvasBase.cpp:112)
6 WebCore 0x111fde164 WebCore::HTMLCanvasElement::toDataURL(WTF::String const&, JSC::JSValue) + 464 (HTMLCanvasElement.cpp:733)
7 WebCore 0x111107520 WebCore::jsHTMLCanvasElementPrototypeFunction_toDataURLBody(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::JSHTMLCanvasElement*) + 216
```
Chris Dumez
(In reply to Chris Dumez from comment #4)
> I suspect this broke photo editing on https://photos.google.com:
> ```
> Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
> 0 libsystem_kernel.dylib 0x1888421fc __pthread_kill + 8
> 1 libsystem_pthread.dylib 0x188879cc0 pthread_kill + 288
> 2 libsystem_c.dylib 0x188789a98 abort + 180
> 3 libc++.1.dylib 0x1887b4174
> std::__1::__libcpp_verbose_abort(char const*, ...) + 92
> 4 WebCore 0x111fabbcc
> std::__1::optional<unsigned long long>::operator*[abi:v160002]() && + 48
> (optional:971) [inlined]
> 5 WebCore 0x111fabbcc
> WebCore::CanvasBase::makeRenderingResultsAvailable() + 336
> (CanvasBase.cpp:112)
> 6 WebCore 0x111fde164
> WebCore::HTMLCanvasElement::toDataURL(WTF::String const&, JSC::JSValue) +
> 464 (HTMLCanvasElement.cpp:733)
> 7 WebCore 0x111107520
> WebCore::jsHTMLCanvasElementPrototypeFunction_toDataURLBody(JSC::
> JSGlobalObject*, JSC::CallFrame*, WebCore::JSHTMLCanvasElement*) + 216
> ```
Filed rdar://109232285.
Matthew Finkel
Re-opening for pull request https://github.com/WebKit/WebKit/pull/13779
EWS
Committed 264019@main (bfc25dc6ca1c): <https://commits.webkit.org/264019@main>
Reviewed commits have been landed. Closing PR #13791 and removing active labels.