Bug 25593

Summary:

Refactor MediaPlayerPviate for Chromium port

Product:

WebKit

Reporter:

Hin-Chung Lam <hclam>

Component:

Platform

Assignee:

Hin-Chung Lam <hclam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, fishd

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
patch + changelog	fishd: review+

Hin-Chung Lam

Reported 2009-05-06 12:36:43 PDT

Remove all the methods from MediaPlayerPrivate from MediaPlayerPrivateChromium.h so it only has one static method.

Attachments
patch + changelog (2.63 KB, patch) 2009-05-06 12:40 PDT, Hin-Chung Lam	fishd: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Hin-Chung Lam

Comment 1 2009-05-06 12:40:23 PDT

Created attachment 30059 [details] patch + changelog This is a refactoring, no layout tests are provided.

Darin Fisher (:fishd, Google)

Comment 2 2009-05-06 12:46:03 PDT

Comment on attachment 30059 [details] patch + changelog >+2009-05-06 hclam <hclam@chromium.org> actually, one nit for next time: please set REAL_NAME in your environment so that prepare-ChangeLog automatically includes your full name instead of "hclam" in the ChangeLog.

Darin Fisher (:fishd, Google)

Comment 3 2009-05-06 12:58:27 PDT

Landed as: http://trac.webkit.org/changeset/43321

Note You need to log in before you can comment on or make changes to this bug.