Bug 255921
| Summary: | Remove Mode::Rfc2045 from ParsedContentType | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Anne van Kesteren <annevk> |
| Component: | DOM | Assignee: | Anne van Kesteren <annevk> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | fred.wang, rbuis, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 260605 | ||
| Bug Blocks: | 255922 | ||
Anne van Kesteren
It seems this was introduced in https://github.com/WebKit/WebKit/commit/e1790e8fee7cebd82248bfbfd735927895b48fab but it's not clear there's a good reason to keep Source/WebCore/platform/encryptedmedia/CDMPrivate.cpp on it.
Rob, Frédéric, if there was a strong reason you did things this way, please let me know.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Rob Buis
(In reply to Anne van Kesteren from comment #0)
> It seems this was introduced in
> https://github.com/WebKit/WebKit/commit/
> e1790e8fee7cebd82248bfbfd735927895b48fab but it's not clear there's a good
> reason to keep Source/WebCore/platform/encryptedmedia/CDMPrivate.cpp on it.
>
> Rob, Frédéric, if there was a strong reason you did things this way, please
> let me know.
IRC that patch just introduced mimesniff mode and left Mode::Rfc2045 usage as before. I do not know encryptedmedia code at all so I can't judge that one, but maybe it is specced somewhere.
Radar WebKit Bug Importer
<rdar://problem/108787747>
Anne van Kesteren
Pull request: https://github.com/WebKit/WebKit/pull/51107
EWS
Committed 300403@main (f10e9e2ba5de): <https://commits.webkit.org/300403@main>
Reviewed commits have been landed. Closing PR #51107 and removing active labels.