Bug 25569

Summary:

make ParserRefCounted use conventional reference counting

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

JavaScriptCore

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
patch	none
Sunspider results with this patch	none
patch	sam: review+

Darin Adler

Reported 2009-05-05 09:58:51 PDT

Maciej suggests that we use a conventional reference counting scheme for parser nodes now that they are no longer kept around after compilation. This should give us a modest speedup.

Attachments
patch (10.06 KB, patch) 2009-05-05 11:10 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Sunspider results with this patch (3.43 KB, text/plain) 2009-05-05 13:44 PDT, Brady Eidson	no flags	Details
patch (11.92 KB, patch) 2009-05-05 15:01 PDT, Darin Adler	sam: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2009-05-05 11:10:13 PDT

Created attachment 30026 [details] patch Can't measure a speedup yet.

Brady Eidson

Comment 2 2009-05-05 13:44:59 PDT

Created attachment 30033 [details] Sunspider results with this patch Sunspider compare with this patch. 1.6% speedup overall. Small slowdown noise on 4 tests.

Darin Adler

Comment 3 2009-05-05 15:01:17 PDT

Created attachment 30035 [details] patch

Darin Adler

Comment 4 2009-05-05 16:50:57 PDT

http://trac.webkit.org/changeset/43259

Note You need to log in before you can comment on or make changes to this bug.