Bug 255440
| Summary: | Remove finishCreation()s that only call its superclass' finishCreation(). | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> |
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Mark Lam
Introduce a DECLARE_DEFAULT_FINISH_CREATION macro to define finishCreation() when ASSERT_ENABLED, and to use Base::finishCreation when not ASSERT_ENABLED. Change code in JSC to use DECLARE_DEFAULT_FINISH_CREATION when finishCreation() is trivial i.e. effectively just calls the superclass version.
Also change CodeGeneratorJS.pm to do that same.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/108034039>
Mark Lam
Pull request: https://github.com/WebKit/WebKit/pull/12732
EWS
Committed 262983@main (7dbeef1bd19f): <https://commits.webkit.org/262983@main>
Reviewed commits have been landed. Closing PR #12732 and removing active labels.