Bug 255340
| Summary: | [ews] Add a script to upload a file to given url | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> |
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aakash_jain, csaavedra, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=255339 | ||
Aakash Jain
Write a script to upload a file to given url.
This would be used by https://bugs.webkit.org/show_bug.cgi?id=255339 "EWS bots should upload directly to S3"
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Aakash Jain
Pull request: https://github.com/WebKit/WebKit/pull/12650
EWS
Committed 262888@main (ab2b21fb6389): <https://commits.webkit.org/262888@main>
Reviewed commits have been landed. Closing PR #12650 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/107961097>
EWS
Committed 259548.688@safari-7615-branch (0500e7adcfa5): <https://commits.webkit.org/259548.688@safari-7615-branch>
Reviewed commits have been landed. Closing PR #559 and removing active labels.
Aakash Jain
Re-opening for pull request https://github.com/apple/WebKit/pull/559
Claudio Saavedra
From https://bugs.webkit.org/show_bug.cgi?id=255819, IIUC there's intention to remove usage of the requests module. Noticed some warnings in the GTK bots because requests is used (which doesn't seem to be installed) (https://ews-build.webkit.org/#/builders/2/builds/9500). Might be a good idea to update the script ot move away from it.
Aakash Jain
We don't have concern with request module as such. The reason for the change in https://bugs.webkit.org/show_bug.cgi?id=255819 is for the code running on server side to convert from synchronous to async code.
If you notice error due to missing requests module on any of your bots, please install requests module.