Bug 255286

Summary: AX: Create TextMarkerRanges based on the TextContent of AXIsolatedObjects.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: AccessibilityAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, tyler_w, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Andres Gonzalez
Reported 2023-04-11 08:21:29 PDT
Needed for stringForTextMarkerRange.
Attachments
Patch (13.99 KB, patch)
2023-04-11 08:35 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-04-11 08:21:42 PDT
<rdar://problem/107883608>
Andres Gonzalez
Comment 2 2023-04-11 08:35:14 PDT
Created attachment 465847 [details] Patch
Tyler Wilcock
Comment 3 2023-04-11 10:10:06 PDT
Comment on attachment 465847 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=465847&action=review Looks good to me once all EWS tests pass. I'd understand if you didn't want to wait through another round of EWS just to fix some typos in the commit message, up to you. > COMMIT_MESSAGE:7 > +TextMarkerRanges were created using the cached AttributedString for some types of AXIsoaltedObjects. However, we need to create TesxtMarkerRanges for objects for which there is no cached AttributedString. This patch uses the TextContent property instead of the cached AttributedString. Typos: AXIsoaltedObjects TesxtMarkerRanges > COMMIT_MESSAGE:11 > +This is needed to implement AXIsolatedObject::stringForTextMarkerRange and related methods off the main thtread. Typo: thtread
Andres Gonzalez
Comment 4 2023-04-11 10:18:15 PDT
(In reply to Tyler Wilcock from comment #3) > Comment on attachment 465847 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=465847&action=review > > Looks good to me once all EWS tests pass. I'd understand if you didn't want > to wait through another round of EWS just to fix some typos in the commit > message, up to you. > > > COMMIT_MESSAGE:7 > > +TextMarkerRanges were created using the cached AttributedString for some types of AXIsoaltedObjects. However, we need to create TesxtMarkerRanges for objects for which there is no cached AttributedString. This patch uses the TextContent property instead of the cached AttributedString. > > Typos: > > AXIsoaltedObjects > TesxtMarkerRanges > > > COMMIT_MESSAGE:11 > > +This is needed to implement AXIsolatedObject::stringForTextMarkerRange and related methods off the main thtread. > > Typo: thtread Thanks! will correct the typos before landing.
EWS
Comment 5 2023-04-11 13:14:13 PDT
Committed 262835@main (14be4a13b9fa): <https://commits.webkit.org/262835@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 465847 [details].
Note You need to log in before you can comment on or make changes to this bug.