Bug 255043
Summary: | [git pre-push] Prevent pushing commits for redacted issues | ||
---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> |
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=254627 |
Jonathan Bedard
Right now, our pre-push hook will prompt a user before pushing a commit for a redacted issue. Instead, we should just prevent users from pushing commits for redacted issues. There should be three notable exceptions to this rule:
1) The commit already exists on a public remote
2) The commit is a cherry-pick of one on a public remote
3) The commit also refers to an issue which is exempt from redaction
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/107673301>
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/12417
EWS
Committed 262635@main (34c241927fad): <https://commits.webkit.org/262635@main>
Reviewed commits have been landed. Closing PR #12417 and removing active labels.