Bug 25501

Summary:

Extra font tag created when changing fonts

Product:

WebKit

Reporter:

Annie Sullivan <sullivan>

Component:

HTML Editing

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric, jparent, michaelthomas, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

URL:

http://www.mozilla.org/editor/midasdemo/

Attachments:

Description	Flags
Patch	none
Patch	none

Annie Sullivan

Reported 2009-04-30 17:14:41 PDT

Steps to reproduce: 1. Go to Midas Demo: http://www.mozilla.org/editor/midasdemo/ 2. Enter the following HTML: text (This is what IE generates when setting the font to Arial.) 3. Uncheck "View HTML Source", highlight "text", and change font to Courier. Actual result: text Expected result: text or just text Lots of editing on different browsers can result in a document filling up with redundant tags. This makes it harder and harder to change the font correctly on all browsers.

Attachments
Patch (3.34 KB, patch) 2010-01-20 23:02 PST, Tony Chang	no flags	Details Formatted Diff Diff
Patch (3.06 KB, patch) 2010-01-21 17:00 PST, Tony Chang	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Tony Chang

Comment 1 2010-01-20 23:02:54 PST

Created attachment 47099 [details] Patch

Tony Chang

Comment 2 2010-01-20 23:04:54 PST

(In reply to comment #1) > Created an attachment (id=47099) [details] > Patch I think the original code wasn't removing the extra font tag because it didn't create the font tag. That said, that seems like a silly reason to keep the extra font tag. E.g., if you unbold a section, webkit doesn't care who created the tags and just remove them.

Darin Adler

Comment 3 2010-01-21 09:54:18 PST

Comment on attachment 47099 [details] Patch r=me

Tony Chang

Comment 4 2010-01-21 17:00:40 PST

Created attachment 47159 [details] Patch

Tony Chang

Comment 5 2010-01-21 17:52:10 PST

Comment on attachment 47159 [details] Patch (same as before with better layout test that uses dumpAsText)

WebKit Commit Bot

Comment 6 2010-01-21 22:53:22 PST

Comment on attachment 47159 [details] Patch Clearing flags on attachment: 47159 Committed r53680: <http://trac.webkit.org/changeset/53680>

WebKit Commit Bot

Comment 7 2010-01-21 22:53:27 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.