Summary: | Remove Range::compareBoundaryPoints(Position, Position) per Darin's suggestion in bug 25056 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||
Component: | HTML Editing | Assignee: | Eric Seidel (no email) <eric> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 25056 | ||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2009-04-30 16:58:42 PDT
Created attachment 29930 [details] Remove Range::compareBoundaryPoints(Position, Position) per Darin's suggestion in bug 25056 11 files changed, 77 insertions(+), 34 deletions(-) Created attachment 29931 [details]
Add a compareBoundaryPoints which takes RangeBoundaryPoints
3 files changed, 32 insertions(+), 11 deletions(-)
Comment on attachment 29930 [details] Remove Range::compareBoundaryPoints(Position, Position) per Darin's suggestion in bug 25056 Is the VisiblePosition version of comparePositions ever used? I couldn't tell from the diff. If not, I suggest removing it. Comment on attachment 29931 [details]
Add a compareBoundaryPoints which takes RangeBoundaryPoints
r=me
Comment on attachment 29930 [details] Remove Range::compareBoundaryPoints(Position, Position) per Darin's suggestion in bug 25056 Mostly looks ok. But please remove this function if it's not actually used. Would rather not add dead code. +int comparePositions(const VisiblePosition& a, const VisiblePosition& b) +{ + return comparePositions(a.deepEquivalent(), b.deepEquivalent()); +} + Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/dom/Range.cpp M WebCore/dom/Range.h M WebCore/editing/ApplyStyleCommand.cpp M WebCore/editing/CompositeEditCommand.cpp M WebCore/editing/DeleteSelectionCommand.cpp M WebCore/editing/SelectionController.cpp M WebCore/editing/VisibleSelection.cpp M WebCore/editing/htmlediting.cpp M WebCore/editing/htmlediting.h M WebCore/page/EventHandler.cpp Committed r44367 M WebCore/ChangeLog M WebCore/dom/Range.cpp M WebCore/dom/Range.h Committed r44368 |