Bug 254717
Summary: | Consider moving wtf/fast_float to a ThirdParty directory | ||
---|---|---|---|
Product: | WebKit | Reporter: | Elliott Williams <emw> |
Component: | Web Template Framework | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW | ||
Severity: | Normal | CC: | mcatanzaro, mmaxfield, webkit-bug-importer, ysuzuki |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Elliott Williams
Right now, it's not clear that we bundle fast_float <https://github.com/fastfloat/fast_float> inside of WTF. There is precedent for a ThirdParty directory nested inside a project directory, e.g. Source/WebCore/PAL/ThirdParty/libavif/. We should do the same thing for fast_float and move it to Source/WTF/ThirdParty/fast_float/.
This ought to be useful for distributions tracking which copyrighted works they ship, and it makes it easier to understand why code is that directory does not always conform to coding style, etc.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
This Apache-licensed code changes the "effective license" of WebKit. I thought WebKit's license was (BSD and LGPLv2+), but surprise! it's actually (BSD and LPGLv2+ and Apache). Notably, it means GPLv2-only applications cannot depend on WebKit (although, fortunately, I doubt any such applications exist).
We need to get the license right. This means either removing this code or else updating https://webkit.org/licensing-webkit/
Yusuke Suzuki
(In reply to Michael Catanzaro from comment #1)
> This Apache-licensed code changes the "effective license" of WebKit. I
> thought WebKit's license was (BSD and LGPLv2+), but surprise! it's actually
> (BSD and LPGLv2+ and Apache). Notably, it means GPLv2-only applications
> cannot depend on WebKit (although, fortunately, I doubt any such
> applications exist).
>
> We need to get the license right. This means either removing this code or
> else updating https://webkit.org/licensing-webkit/
libwebrtc is Apache license for example.
Yusuke Suzuki
Also, ANGLE, pdfjs
Michael Catanzaro
OK, we need to update https://webkit.org/licensing-webkit/
Radar WebKit Bug Importer
<rdar://problem/107690836>