Bug 25471 – fast/forms/textarea-metrics.html failing on windows

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Ojan Vafai]

The expected results are just wrong. There's a race with JS tests that have setTimeouts in them. See http://build.webkit.org/results/Windows%20Release%20(Tests)/r43017%20(546)/fast/forms/textarea-metrics-pretty-diff.html and bug 25469.

For now the test just needs to be modified to not use a setTimeout.

[Ojan Vafai]

Created attachment 29899 [details]
2009-04-29  Ojan Vafai  <[e-mail]>


        Reviewed by NOBODY (OOPS!).

        Fix this test to only use a setTimeout in IE.
        It doesn't need a timeout in WebKit and the
        timeout requires using waitUntilDone/notifyDone,
        which doesn't play nicely with JS tests.

        See https://bugs.webkit.org/show_bug.cgi?id=25471

        * fast/forms/resources/textarea-metrics.js:
        (assertTextareaMetrics):
        * fast/forms/textarea-metrics-expected.txt:
        * platform/win/fast/forms/textarea-metrics-expected.txt:
        * platform/win/Skipped:
---
 5 files changed, 60 insertions(+), 60 deletions(-)

[Eric Seidel (no email)]

Comment on attachment 29899 [details]
2009-04-29  Ojan Vafai  <[e-mail]>

r=me

[Ojan Vafai]

http://trac.webkit.org/changeset/43031