Bug 254693
| Summary: | [Wasm-GC] Implement casts at Wasm-JS function call boundaries | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Asumu Takikawa <asumu> |
| Component: | WebAssembly | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | joseph.j.griego, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 247394 | ||
Asumu Takikawa
When calling into Wasm from JS, `ToWebAssemblyValue` needs to be called on JS values to convert them to Wasm values. For GC types, this is currently not implemented.
In general, it's necessary to add a `extern.internalize` and `ref.cast` to the target Wasm type on such a call.
In the other direction, `ToJSValue` is typically a no-op for Wasm GC values, but it still needs to be enabled.
The machinery to do these casts is already in JSC, but it needs to be hooked up to code in JSToWasm.cpp and WasmToJS.cpp to do the right thing.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/107679474>
Asumu Takikawa
Pull request: https://github.com/WebKit/WebKit/pull/19550
EWS
Committed 270460@main (5aa61e8c766a): <https://commits.webkit.org/270460@main>
Reviewed commits have been landed. Closing PR #19550 and removing active labels.
David Degazio
*** Bug 263467 has been marked as a duplicate of this bug. ***