Bug 254562
| Summary: | WebKit needs to pass along NotificationOptions.silent to API clients | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | lehu <hi> |
| Component: | Platform | Assignee: | Brady Eidson <beidson> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | beidson, pwadeveloper2, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari 16 | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=254969 | ||
lehu
Notification pushed by WebPush does not play alert sound both on iOS and macOS.
And here is a demo to reoccur this issue.
https://bugs.webkit.org/show_bug.cgi?id=252544#c3
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/107424158>
Brady Eidson
WebKit itself does not display notifications, and cannot affect whether or not sound plays.
But for clients to be able to make the "sound or silent?" decision, WebKit needs to pass along the silent flag from NotificationOptions.
Let's do that here. Retitling to:
WebKit needs to pass along NotificationOptions.silent to API clients
Brady Eidson
Pull request: https://github.com/WebKit/WebKit/pull/12953
EWS
Committed 263184@main (c33fee9a5907): <https://commits.webkit.org/263184@main>
Reviewed commits have been landed. Closing PR #12953 and removing active labels.