Bug 254490
| Summary: | Serialising web fonts duplicates the font custom data in the GPUP | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Matt Woodrow <mattwoodrow> |
| Component: | Text | Assignee: | Matt Woodrow <mattwoodrow> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | Hironori.Fujii, mmaxfield, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=254774 https://bugs.webkit.org/show_bug.cgi?id=254708 |
||
| Bug Depends on: | |||
| Bug Blocks: | 268233 | ||
Matt Woodrow
In the Web Process, all Font instances from the same web font share the same underlying font data (via Font::CreationData).
When we serialise fonts to the GPUP we serialise the font data each time, resulting in extra memory usage and time spent parsing the data each time.
<rdar://106965215>
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Matt Woodrow
Pull request: https://github.com/WebKit/WebKit/pull/11987
Matt Woodrow
Pull request: https://github.com/apple/WebKit/pull/502
EWS
Committed 262263@main (b917345920e9): <https://commits.webkit.org/262263@main>
Reviewed commits have been landed. Closing PR #11987 and removing active labels.
Fujii Hironori
Regressed: Bug 254708 – REGRESSION(262263@main) [Win] ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) in font tests
Simon Fraser (smfr)
Right; reverting via bug 254774.
Matt Woodrow
Re-opening for pull request https://github.com/WebKit/WebKit/pull/12221
EWS
Committed 262435@main (403125028b31): <https://commits.webkit.org/262435@main>
Reviewed commits have been landed. Closing PR #12221 and removing active labels.