Bug 254450

Summary:

[ews-build] Make should_send_email_for_patch asynchronous

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ews-watchlist, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Test patch	jbedard: commit-queue-

Description Jonathan Bedard 2023-03-24 17:32:51 PDT

should_send_email_for_patch should be asynchronous because it logs to the buildbot log. More important, our code which fetches a patch from bugzilla should be asynchronous, and that code is invoke from should_send_email_for_patch, so should_send_email_for_patch blocks making requests to Bugzilla asynchronous.

Comment 1 Radar WebKit Bug Importer 2023-03-24 17:33:57 PDT

<rdar://problem/107209666>

Comment 2 Jonathan Bedard 2023-03-24 17:34:42 PDT

Pull request: https://github.com/WebKit/WebKit/pull/11958

Comment 3 Jonathan Bedard 2023-04-19 11:42:28 PDT

Created attachment 465984 [details]
Patch

Comment 4 Jonathan Bedard 2023-04-19 12:19:29 PDT

Created attachment 465986 [details]
Test patch

Comment 5 EWS 2023-04-20 08:05:41 PDT

Committed 263175@main (b98dad5b233f): <https://commits.webkit.org/263175@main>

Reviewed commits have been landed. Closing PR #11958 and removing active labels.