Bug 254420

Summary: AX: Move AXStringForTextMarkerRange off of the main thread.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: AccessibilityAssignee: Andres Gonzalez <andresg_22>
Status: NEW    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch andresg_22: review?, ews-feeder: commit-queue-

Andres Gonzalez
Reported 2023-03-24 07:34:56 PDT
Improve performance in ITM.
Attachments
Patch (23.50 KB, patch)
2023-03-24 07:52 PDT, Andres Gonzalez 		andresg_22: review?
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-03-24 07:35:07 PDT
<rdar://problem/107185989>
Andres Gonzalez
Comment 2 2023-03-24 07:52:15 PDT
Created attachment 465571 [details] Patch
chris fleizach
Comment 3 2023-03-24 09:48:06 PDT
Comment on attachment 465571 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=465571&action=review > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:956 > + if (start < text.length() && end <= text.length()) end is an index here right? so we would to make sure it's just < text.length() ? > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:957 > + return text.substring(start, end - start); likewise if the last parameter is length do we want end - start + 1 ? For example the text "test" start = 0 end = 3 ?
Note You need to log in before you can comment on or make changes to this bug.