Bug 25430

Summary:

Enable loading style sheet for UI controls for media elements in Chromium port

Product:

WebKit

Reporter:

Hin-Chung Lam <hclam>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
patch + changelog	dglazkov: review+

Hin-Chung Lam

Reported 2009-04-27 14:01:58 PDT

Implement a virtual method in RenderTheme to provide style sheet for media controls in Chromium port.

Attachments
patch + changelog (1.91 KB, patch) 2009-04-27 14:07 PDT, Hin-Chung Lam	dglazkov: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Hin-Chung Lam

Comment 1 2009-04-27 14:07:35 PDT

Created attachment 29826 [details] patch + changelog Just the patch with change log, since <video> and <audio> in chromium is not ready to run through layout tests and the style for default ui is subject to change so no layout tests are provided. This patch is just to enable loading the style sheet so change the default style sheet would have effects.

Sam Weinig

Comment 2 2009-04-27 16:04:48 PDT

In the future, please don't remove the NOBODY (OOPS!) from the ChangeLog. We have post commit scripts that check to make sure the lander didn't forget to update the reviewer by checking for it.

Eric Seidel (no email)

Comment 3 2009-04-29 13:14:33 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/rendering/RenderThemeChromiumWin.cpp M WebCore/rendering/RenderThemeChromiumWin.h Committed r43002

Note You need to log in before you can comment on or make changes to this bug.