Bug 254269

Summary: @counter-styles: Single symbol "" does not behave correctly
Product: WebKit Reporter: Vitor Roriz <vitor.roriz>
Component: CSSAssignee: Vitor Roriz <vitor.roriz>
Status: RESOLVED FIXED    
Severity: Normal CC: ntim, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://github.com/web-platform-tests/wpt/pull/39143

Description Vitor Roriz 2023-03-22 07:17:53 PDT
For a system that accepts a single symbol, like cyclic, if we input a symbol that is an empty string,
the text representation is being considered invalid and it is falling back to 'decimal'.
This is is wrong, since empty string is a valid string.

Example:

  @counter-style foo {
    system: cyclic;
    symbols: "" "@";
    prefix: "";
    suffix: "";
  }
Comment 1 Radar WebKit Bug Importer 2023-03-22 07:18:04 PDT
<rdar://problem/107053810>
Comment 2 Vitor Roriz 2023-03-22 08:13:50 PDT
Pull request: https://github.com/WebKit/WebKit/pull/11810
Comment 3 Vitor Roriz 2023-03-22 09:19:33 PDT
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/39143
Comment 4 EWS 2023-03-22 10:34:37 PDT
Committed 261971@main (140b74df15a9): <https://commits.webkit.org/261971@main>

Reviewed commits have been landed. Closing PR #11810 and removing active labels.