Bug 254099
| Summary: | MediaSample should use integer as track id rather than AtomString | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Component: | Media | Assignee: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | vwatermeier, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jean-Yves Avenard [:jya]
All instances of track ID are using either int or uint ; except for MediaSample that is using AtomString forcing to have back and forth conversion whenever we are checking or searching for a track.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/106884653>
Jean-Yves Avenard [:jya]
Pull request: https://github.com/WebKit/WebKit/pull/20901
EWS
Committed 271419@main (b3ffcc0a9df7): <https://commits.webkit.org/271419@main>
Reviewed commits have been landed. Closing PR #20901 and removing active labels.
Vivienne Watermeier
I'm currently working on a similar patch for our GTK/WPE ports, and I'd like to ask for clarification on a few points:
- How do you handle MediaStream? The spec suggests using UUIDs, and thats what we do so far. I've tried to see how TrackIDs are set in Apple ports, but I didn't find where that happens.
- The commit mentions using StdUnorderedMap instead of HashMap, can you elaborate what the issue with HashMap is?
Thanks!