Summary: | [GTK] incorrectly fallsback on cancellation | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gustavo Noronha (kov) <gustavo> | ||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | xan.lopez | ||||||||
Priority: | P2 | Keywords: | Gtk | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Gustavo Noronha (kov)
2009-04-26 10:05:36 PDT
Created attachment 29803 [details]
Fix fallback and cancellation handling
WebKit/gtk/ChangeLog | 16 ++++++++++++++++
WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp | 8 +++++++-
2 files changed, 23 insertions(+), 1 deletions(-)
Created attachment 29809 [details]
Do not fallback on cancellation and load interruption caused by policy change.
WebKit/gtk/ChangeLog | 14 ++++++++++++++
WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp | 3 +--
2 files changed, 15 insertions(+), 2 deletions(-)
Created attachment 29810 [details]
Check if we should use the fallback content in didFailLoad.
WebKit/gtk/ChangeLog | 14 ++++++++++++++
WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp | 6 ++++++
2 files changed, 20 insertions(+), 0 deletions(-)
Comment on attachment 29809 [details]
Do not fallback on cancellation and load interruption caused by policy change.
Looks good.
Comment on attachment 29810 [details]
Check if we should use the fallback content in didFailLoad.
Perhaps you can add the same comment to the signal emission than Jan did, to be consistent. r=me otherwise.
|