Bug 25385

Summary: Upstream changes to V8 bindings for supporting nested workers.
Product: WebKit Reporter: Jian Li <jianli>
Component: WebCore Misc.Assignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=225045
Attachments:
Description Flags
Proposed Patch
dglazkov: review-
Proposed Patch dglazkov: review+

Jian Li
Reported 2009-04-24 16:16:41 PDT
Upstream changes to V8 bindings for supporting nested workers.
Attachments
Proposed Patch (6.32 KB, patch)
2009-04-24 16:20 PDT, Jian Li 		dglazkov: review-
DetailsFormatted DiffDiff
Proposed Patch (6.27 KB, patch)
2009-05-05 17:39 PDT, Jian Li 		dglazkov: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jian Li
Comment 1 2009-04-24 16:20:01 PDT
Created attachment 29777 [details] Proposed Patch
Dimitri Glazkov (Google)
Comment 2 2009-05-05 15:56:02 PDT
Comment on attachment 29777 [details] Proposed Patch Style looks good! :) > + if (result.IsEmpty()) { > + v8::Local<v8::Object> object = toV8(type, type, impl); > + if (!object.IsEmpty()) > + static_cast<Worker*>(impl)->ref(); > + result = v8::Persistent<v8::Object>::New(object); > + V8Proxy::SetJSWrapperForDOMObject(impl, result); > + } > + return result; Would it be a bit more clear to inverse this: if (!result.IsEmpty()) return result; ... > + return PassRefPtr<EventListener>(); Can just return 0;
Jian Li
Comment 3 2009-05-05 17:39:35 PDT
Created attachment 30042 [details] Proposed Patch All fixed. Thanks.
Dimitri Glazkov (Google)
Comment 4 2009-05-05 18:24:52 PDT
Comment on attachment 30042 [details] Proposed Patch Land it! :)
David Levin
Comment 5 2009-05-06 14:14:41 PDT
Assign to levin for landing.
David Levin
Comment 6 2009-05-06 15:03:36 PDT
http://trac.webkit.org/changeset/43328
Note You need to log in before you can comment on or make changes to this bug.