Bug 25382

Summary:

Move scriptStateFromNode to ScriptState

Product:

WebKit

Reporter:

Dimitri Glazkov (Google) <dglazkov>

Component:

WebCore Misc.

Assignee:

Dimitri Glazkov (Google) <dglazkov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Move scriptStateFromNode to ScriptState, v1.	eric: review-
Move scriptStateFromNode to ScriptState, v2.	eric: review+

Dimitri Glazkov (Google)

Reported 2009-04-24 16:07:02 PDT

Now that the file is more than just a typedef and has scriptStateFromPage in it, it seems logical.

Attachments
Move scriptStateFromNode to ScriptState, v1. (4.85 KB, patch) 2009-04-24 16:08 PDT, Dimitri Glazkov (Google)	eric: review-	Details Formatted Diff Diff
Move scriptStateFromNode to ScriptState, v2. (6.29 KB, patch) 2009-04-27 11:21 PDT, Dimitri Glazkov (Google)	eric: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Dimitri Glazkov (Google)

Comment 1 2009-04-24 16:08:32 PDT

Created attachment 29774 [details] Move scriptStateFromNode to ScriptState, v1. WebCore/ChangeLog | 18 ++++++++++++++++++ WebCore/bindings/js/JSDOMBinding.cpp | 15 --------------- WebCore/bindings/js/JSDOMBinding.h | 2 -- WebCore/bindings/js/ScriptState.cpp | 16 ++++++++++++++++ WebCore/bindings/js/ScriptState.h | 6 +++--- WebCore/dom/NodeFilter.h | 1 - WebCore/dom/NodeIterator.h | 1 - WebCore/dom/TreeWalker.h | 1 - 8 files changed, 37 insertions(+), 23 deletions(-)

Eric Seidel (no email)

Comment 2 2009-04-27 10:39:49 PDT

Comment on attachment 29774 [details] Move scriptStateFromNode to ScriptState, v1. Seems to be missing the V8 side of things...

Dimitri Glazkov (Google)

Comment 3 2009-04-27 11:21:42 PDT

Created attachment 29821 [details] Move scriptStateFromNode to ScriptState, v2. WebCore/ChangeLog | 19 +++++++++++++++++++ WebCore/bindings/js/JSDOMBinding.cpp | 15 --------------- WebCore/bindings/js/JSDOMBinding.h | 2 -- WebCore/bindings/js/ScriptState.cpp | 16 ++++++++++++++++ WebCore/bindings/js/ScriptState.h | 8 ++++---- WebCore/bindings/v8/ScriptState.cpp | 11 +++++++++++ WebCore/bindings/v8/ScriptState.h | 4 +++- WebCore/dom/NodeFilter.h | 1 - WebCore/dom/NodeIterator.h | 1 - WebCore/dom/TreeWalker.h | 1 - 10 files changed, 53 insertions(+), 25 deletions(-)

Eric Seidel (no email)

Comment 4 2009-04-27 11:23:46 PDT

Comment on attachment 29821 [details] Move scriptStateFromNode to ScriptState, v2. I don't understand the #include <interpreter/CallFrame.h> include, but otherwise this looks fine!

Dimitri Glazkov (Google)

Comment 5 2009-04-27 12:46:35 PDT

Landed as http://trac.webkit.org/changeset/42901.

Note You need to log in before you can comment on or make changes to this bug.