Bug 25380 – LayoutTests/media/video-played.html has a race condition when starting the test.

• Component: New Bugs
• Status: RESOLVED FIXED

[Pierre d'Herbemont]

LayoutTests/media/video-played.html has a race condition when starting the test.

The test may attempt to call video.play() even before the 'canplay' event has been fired.

[Pierre d'Herbemont]

Created attachment 29768 [details]
patch v1.

[Simon Fraser (smfr)]

Comment on attachment 29768 [details]
patch v1.

> Index: LayoutTests/ChangeLog
> ===================================================================
> --- LayoutTests/ChangeLog	(revision 42845)
> +++ LayoutTests/ChangeLog	(working copy)
> @@ -1,3 +1,16 @@
> [phone]  Pierre d'Herbemont  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Fixed a race condition on the first 'played' attribute test start.
> +
> +        Previously we were starting nearly right away to play, and probably
> +        before receiving the 'canplay' event. Now we ensure we'll wait for
> +        that 'canplay' event before attempting to play.

"...before starting the tests."

>                  waitForEvent("loadedmetadata");
> -                waitForEvent("canplay", canplay);
> +                waitForEvent("canplay", canplay); // Will triggers nextTest() which launches the tests.

"Will trigger"

r=me

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/42848