Bug 253533
| Summary: | [SOUP] HTTP/2 status text WPTs fail on WPE and GTK | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ben Nham <nham> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bugs-noreply, mcatanzaro, webkit-bug-importer |
| Priority: | P2 | ||
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 176479, 253043 | ||
| Bug Blocks: | |||
Ben Nham
These WPTs fail when we fix the WPT test runner to actually run the H2 test cases over H2 (253043):
imported/w3c/web-platform-tests/fetch/api/basic/status.h2.any-expected.txt
imported/w3c/web-platform-tests/fetch/api/basic/status.h2.any.worker-expected.txt
imported/w3c/web-platform-tests/xhr/status.h2.window-expected.txt
Example diff:
```
--- /home/ews/worker/WPE-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/fetch/api/basic/status.h2.any-expected.txt
+++ /home/ews/worker/WPE-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/fetch/api/basic/status.h2.any-actual.txt
@@ -1,9 +1,9 @@
-FAIL statusText over H2 for status 200 should be the empty string assert_equals: statusText should be the empty string expected "" but got "OMG"
-FAIL statusText over H2 for status 210 should be the empty string assert_equals: statusText should be the empty string expected "" but got "OMG"
-FAIL statusText over H2 for status 400 should be the empty string assert_equals: statusText should be the empty string expected "" but got "OMG"
-FAIL statusText over H2 for status 404 should be the empty string assert_equals: statusText should be the empty string expected "" but got "OMG"
-FAIL statusText over H2 for status 410 should be the empty string assert_equals: statusText should be the empty string expected "" but got "OMG"
-FAIL statusText over H2 for status 500 should be the empty string assert_equals: statusText should be the empty string expected "" but got "OMG"
-FAIL statusText over H2 for status 502 should be the empty string assert_equals: statusText should be the empty string expected "" but got "OMG"
+FAIL statusText over H2 for status 200 should be the empty string assert_equals: statusText should be the empty string expected "" but got "OK"
+FAIL statusText over H2 for status 210 should be the empty string assert_equals: statusText should be the empty string expected "" but got "Unknown Error"
+FAIL statusText over H2 for status 400 should be the empty string assert_equals: statusText should be the empty string expected "" but got "Bad Request"
+FAIL statusText over H2 for status 404 should be the empty string assert_equals: statusText should be the empty string expected "" but got "Not Found"
+FAIL statusText over H2 for status 410 should be the empty string assert_equals: statusText should be the empty string expected "" but got "Gone"
+FAIL statusText over H2 for status 500 should be the empty string assert_equals: statusText should be the empty string expected "" but got "Internal Server Error"
+FAIL statusText over H2 for status 502 should be the empty string assert_equals: statusText should be the empty string expected "" but got "Bad Gateway"
```
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ben Nham
Looks like Joseph's fix for this issue only worked for Cocoa platforms and not for other platforms: https://github.com/WebKit/WebKit/commit/93719e196089a762755edc915cbb597f32112394