| Summary: | Support the back/forward/stop/refresh multimedia keys | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Meyer <ben> | ||||||
| Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | staikos | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Benjamin Meyer
2009-04-23 20:45:12 PDT
Created attachment 29725 [details]
patch to fix the bug
Comment on attachment 29725 [details]
patch to fix the bug
This was r+'d without a ChangeLog. Please don't do that unless you plan to land it yourself. :(
Are you really afraid this is going to be checked in without a changelog? Created attachment 31290 [details]
patch to fix the bug
with prepare-changelog run
(In reply to comment #3) > Are you really afraid this is going to be checked in without a changelog? No. :) It's just I went to try and land it, and I couldn't easily because it didn't have a ChangeLog. :) The ChangeLog doesn't have a link to the bug in question. We really need to fix prepare-ChangeLog to add those for you. :) (In reply to comment #5) > (In reply to comment #3) > > Are you really afraid this is going to be checked in without a changelog? > > No. :) It's just I went to try and land it, and I couldn't easily because it > didn't have a ChangeLog. :) As this was a git patch the changelog text was there to be reviewed even if it wasn't in the changelog file, I didn't write a changelog, just ran the script to create it for the second patch. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/qt/Api/qwebpage.cpp M WebKit/qt/ChangeLog Committed r44704 M WebKit/qt/ChangeLog M WebKit/qt/Api/qwebpage.cpp r44704 = cfd7be9b10bab318302b163d42d971858c6e87f8 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk |