Bug 25351

Summary: Enable copying image to the clipboard
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: WebKitGTKAssignee: Gustavo Noronha (kov) <gustavo>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Gtk
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
enable copying image to clipboard eric: review+

Gustavo Noronha (kov)
Reported 2009-04-23 17:06:32 PDT
Now that we have a way to turn images to GdkPixbuf's, we can enable the code that is commented out in PasteBoardGtk
Attachments
enable copying image to clipboard (1.54 KB, patch)
2009-04-23 17:07 PDT, Gustavo Noronha (kov) 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2009-04-23 17:07:57 PDT
Created attachment 29719 [details] enable copying image to clipboard
Eric Seidel (no email)
Comment 2 2009-04-27 17:14:02 PDT
Comment on attachment 29719 [details] enable copying image to clipboard Looks wrong. Why is it OK to ASSERT here in the gtk version and not in the mac version?
Gustavo Noronha (kov)
Comment 3 2009-05-04 16:46:10 PDT
Comment on attachment 29719 [details] enable copying image to clipboard (In reply to comment #2) > (From update of attachment 29719 [details] [review]) > Looks wrong. Why is it OK to ASSERT here in the gtk version and not in the mac > version? From my reading of the code, the same ASSERT's exist in Mac. Am I missing something?: void Pasteboard::writeImage(Node* node, const KURL& url, const String& title) { ASSERT(node); [...] ASSERT(node->renderer() && node->renderer()->isImage()); [...] ASSERT(cachedImage); [...] ASSERT(image); [...] }
Eric Seidel (no email)
Comment 4 2009-05-19 19:38:04 PDT
Comment on attachment 29719 [details] enable copying image to clipboard Shrugs. rs=me
Gustavo Noronha (kov)
Comment 5 2009-05-20 07:52:17 PDT
Landed as r43909, thanks Eric =).
Note You need to log in before you can comment on or make changes to this bug.