| Summary: | Pass MessageLevel and MessageSource into the ChromeClient::addMessageToConsole | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||
| Component: | WebCore Misc. | Assignee: | Pavel Feldman <pfeldman> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dglazkov, timothy | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Pavel Feldman
2009-04-23 07:41:02 PDT
Created attachment 29710 [details]
patch
Adding Timothy to CC. BTW, you don't need to remove "Reviewed by NOBODY (OOPS!)" from the ChangeLog. Comment on attachment 29710 [details]
patch
Patch looks fine. But why is this needed?
(In reply to comment #3) > (From update of attachment 29710 [details] [review]) > Patch looks fine. But why is this needed? > Hm.. I thought I replied to this one. Anyway, posting again. Our async/out-of-process version of WebInspector is currently not based on InspectorController. The reason was that we did not want to interfere with Dmitry's unforking effort, yet wanted to experiment. So we came up with these agents concept that basically mimic InspectorController, but separating 'agent' nature from the 'transport'. Now that InspectorController is unforked, I am planning to bring these concepts into the WebKit land and use what we have in Chromium as a proof of concept / experimental playground. It will take me some time to split InspectorController and I don't want Chromium guys to be blocked by that. Hence I want to expose events that are missing in clients, namely: console severity and xmlhttprequest data. I realize that this is somewhat a temporary measure, but I think it will serve us all well. Does it make sence? Yes, makes sense. It would be good to give a brief reason when posting patches so we don't have to ask/wonder. Thanks for explaining! Comment on attachment 29710 [details]
patch
Please update the patch to include the nice comments you discussed with Timonthy. That way someone else can land it w/o thinking about it.
Created attachment 29913 [details]
patch
(In reply to comment #6) > (From update of attachment 29710 [details] [review]) > Please update the patch to include the nice comments you discussed with > Timonthy. That way someone else can land it w/o thinking about it. > Done Comment on attachment 29913 [details]
patch
Don't forget a URL in the ChangeLog. But I'll fix up and land shortly.
Landed as http://trac.webkit.org/changeset/43063. |