Bug 253348
| Summary: | Use smart pointers for PageConfiguration | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> |
| Component: | WebCore Misc. | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dpino, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Alex Christensen
...
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/106214366>
Alex Christensen
Pull request: https://github.com/WebKit/WebKit/pull/11033
EWS
Committed 261225@main (c4ee0780b398): <https://commits.webkit.org/261225@main>
Reviewed commits have been landed. Closing PR #11033 and removing active labels.
Diego Pino
After this patch, I'm getting the following build error in WinCairo:
```
57>WebPage.obj : error LNK2019: unresolved external symbol "public: virtual __cdecl WebKit::WebChromeClient::~WebChromeClient(void)" (??1WebChromeClient@WebKit@@UEAA@XZ) referenced in function "public: virtual void * __cdecl WebKit::WebChromeClient::`scalar deleting destructor'(unsigned int)" (??_GWebChromeClient@WebKit@@UEAAPEAXI@Z)
```
Apparently WinCairo build bot hasn't detected this build error.
https://build.webkit.org/#/builders/731
I'm doing a clean build. I wonder whether a clean build in the CI bot may trigger the issue.
My environment is:
- OS: Windows10.
- Compiler: Microsoft Visual Studio 2022.
Diego Pino
Re-opening for pull request https://github.com/webkit/webkit/pull/11148
EWS
Committed 261327@main (89cc5666c25a): <https://commits.webkit.org/261327@main>
Reviewed commits have been landed. Closing PR #11148 and removing active labels.