Bug 253145
Summary: | REGRESSION(254676@main): [GTK][WPE] Remote Web Inspector: the remote inspector(HTTP) does not work from any browsers | ||
---|---|---|---|
Product: | WebKit | Reporter: | Przemyslaw Gorszkowski <pgorszkowski> |
Component: | Web Inspector | Assignee: | Przemyslaw Gorszkowski <pgorszkowski> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | cgarcia, inspector-bugzilla-changes, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Przemyslaw Gorszkowski
If I try to connect to webkit(gtk/wpe) from any browser(chrome, ff, webkitgtk-minibrowser) it display empty site. By inspect inspector site there is error:
typeerror: InspectorFrontendHost.engineeringSettingsAllowed is not a function. (In 'InspectorFrontendHost.engineeringSettingsAllowed()', 'InspectorFrontendHost.engineeringSettingsAllowed' is undefined)
It is a regression after https://github.com/WebKit/WebKit/commit/2326b1146886546de0d44f6aa85415b2e1257b8a
The missing function has to be added to: Source/WebInspectorUI/UserInterface/Base/BrowserInspectorFrontendHost.js to fix this error.
Reproduction step:
1. open any site via minibrowser:
WEBKIT_INSPECTOR_HTTP_SERVER="127.0.0.1:9225" Tools/Scripts/run-minibrowser --gtk --release http://www.igalia.com
2. try to connect to is via remote inspector(firefox, chrome, minibrowser)
Tools/Scripts/run-minibrowser --gtk --release http://127.0.0.1:9225
Inspector site is empty and there is error in inspector:
typeerror: InspectorFrontendHost.engineeringSettingsAllowed is not a function. (In 'InspectorFrontendHost.engineeringSettingsAllowed()', 'InspectorFrontendHost.engineeringSettingsAllowed' is undefined)
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Przemyslaw Gorszkowski
Pull request: https://github.com/WebKit/WebKit/pull/10857
EWS
Committed 261056@main (1506a7bfdb72): <https://commits.webkit.org/261056@main>
Reviewed commits have been landed. Closing PR #10857 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/106133407>